search

aaronpowell / ps-nvm

PowerShell module for managing multiple Node.js versions
MIT License
127 stars 25 forks source link

Log to Write-Information, not by outputting strings #69

Closed felixfbecker closed 6 years ago

felixfbecker commented 6 years ago

This allows log output to be controlled by log levels.

aaronpowell commented 6 years ago

Hmm, those test failures are odd...

felixfbecker commented 6 years ago

I know why, they asserted what I changed ;)

aaronpowell commented 6 years ago

Oh!

Shows how much attention I pay to how our tests work 😝

codecov[bot] commented 6 years ago

Codecov Report

Merging #69 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   90.26%   90.26%           
=======================================
  Files           1        1           
  Lines         113      113           
=======================================
  Hits          102      102           
  Misses         11       11
Impacted Files Coverage Δ
nvm.psm1 90.26% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f1e0ecc...ec8ffbd. Read the comment docs.

aaronpowell commented 6 years ago

Want to do a minor version bump in the psd1 and then it can be merged and released.

felixfbecker commented 6 years ago

Can't we merge this first and release it together with the other PR? (bump the version on master)