aaronpowell / ps-nvm

PowerShell module for managing multiple Node.js versions
MIT License
127 stars 25 forks source link

Fixing #71 #72

Closed aaronpowell closed 6 years ago

aaronpowell commented 6 years ago

Regex didn't cater for the v10 release of nodejs

codecov[bot] commented 6 years ago

Codecov Report

Merging #72 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   90.26%   90.26%           
=======================================
  Files           1        1           
  Lines         113      113           
=======================================
  Hits          102      102           
  Misses         11       11
Impacted Files Coverage Δ
nvm.psm1 90.26% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d76ee5...16ad076. Read the comment docs.

felixfbecker commented 6 years ago

I just been hit by this bug too 😭 > $env:PATH /usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v8.11.1/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v8.11.1/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v8.11.1/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v10.0.0/bin:/usr/local/share/powershell/Modules/nvm/2.1.0/vs/v8.11.1/bin:/usr/local/opt/qt/bin:/Users/felix/google-cloud-sdk/bin:/Users/felix/go/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/usr/local/go/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/Library/TeX/texbin:./node_modules/.bin:/usr/local/microsoft/powershell/6.0.1:/Users/felix/.nvm/versions/node/v9.6.1/bin:/usr/local/opt/qt/bin:/Users/felix/.local/share/powershell/Modules/nvm/1.7.0/vs/v8.9.1/bin:/Users/felix/google-cloud-sdk/bin:/Users/felix/go/bin:/usr/local/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/TeX/texbin:/usr/local/go/bin:/usr/local/share/dotnet:/opt/X11/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/Applications/Xamarin Workbooks.app/Contents/SharedSupport/path-bin