jfhbrook commented 4 years ago

As promised - #94 with the alias removed. To recap, this:

Adds simple directions for using PSScriptAnalyzer for linting
Changes a variable name so as to not shadow the automatic $args variable inside a function
Adds ShouldProcess support to functions with names that start with Set

I decided to punt on updating the tests to use the latest Pester - this work should probably still be done, but I'd rather not send a PR that half-asses it.

aaronpowell commented 4 years ago

Drat, looks like Pester 5 has quite a lot of changes in it that are causing the build to fail.

I'm going to make a change where I pin Pester to v4 for the time being so the PR can be reviewed and separately Pester 5 can be investigated.

aaronpowell commented 4 years ago

I've just updated the tests to use Pester 5 and merged that into your branch.

codecov[bot] commented 4 years ago

Codecov Report

Merging #95 into master will increase coverage by 0.22%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   81.36%   81.59%   +0.22%     
==========================================
  Files           2        2              
  Lines         161      163       +2     
==========================================
+ Hits          131      133       +2     
  Misses         30       30

Impacted Files	Coverage Δ
nvm.psm1	`82.69% <100.00%> (+0.22%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3503d0...fd6b596. Read the comment docs.

aaronpowell / ps-nvm

Linting v2 #95

Codecov Report