search

aaronpowell / ps-nvm

PowerShell module for managing multiple Node.js versions
MIT License
127 stars 26 forks source link

Support and try to detect ArmV7L #97

Closed vincentfiestada closed 3 years ago

vincentfiestada commented 4 years ago

NodeJS releases may not have a Linux distribution marked with the "arm" architecture. For example, the Raspberry Pi 4, which has the "armhf" architecture, must use the "armv7l" release.

This PR adds "ArmV7L" to the list of valid architectures and tries to detect if this is the current architecture.

codecov[bot] commented 4 years ago

Codecov Report

Merging #97 into master will increase coverage by 0.34%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   81.36%   81.70%   +0.34%     
==========================================
  Files           2        2              
  Lines         161      164       +3     
==========================================
+ Hits          131      134       +3     
  Misses         30       30
Impacted Files Coverage Δ
nvm.psm1 82.80% <100.00%> (+0.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3503d0...dcea27d. Read the comment docs.

vincentfiestada commented 4 years ago

Hi, @aaronpowell. Could you take a look at this when you have some time? I ran into an issue while trying to use ps-nvm on Powershell Core running on a Raspberry Pi. First, it detected the architecture as "Arm" but Linux releases are marked "armv7l" or "arm64" (at least for NodeJS v14.x). I also couldn't force it to use "armv7l" because it was not considered a valid architecture.