aaronraimist / element-themes

A place to share themes for Element. PRs with new themes are welcome!
The Unlicense
233 stars 55 forks source link

Update Discord Dark theme, improve colors #33

Closed Oha-you closed 3 years ago

Oha-you commented 3 years ago

There are some problems with current Discord Dark theme:

Since both Discord and Element are based on Electron, it's easy to extract native colors from Inspector (Ctrl+Shift+I). That's why I added some values with opacity (8 hex characters), taken directly from native CSS. accent-color is a bit different: I took Discord's official value (#5865f2) and made it lighter with a SASS function:

This helps to achieve a more similar look, but also doesn't make it harder to read highlighted text.

I changed theme title too because otherwise people won't be able to see new colors (see https://github.com/vector-im/element-web/issues/13222). Unfortunately there's no way to remove themes added from URLs as well: https://github.com/vector-im/element-web/issues/13221

Comparison:

Native Discord window ![2021-08-25_194654](https://user-images.githubusercontent.com/82098328/130838490-74dc8f42-6a23-456c-acd0-9e726ec4b5a3.png)
New colors (this PR) ![2021-08-25_194202_1](https://user-images.githubusercontent.com/82098328/130841135-88fa1ea7-8497-4c54-b052-2af70253c54f.png)
Old colors ![2021-08-25_194142_1](https://user-images.githubusercontent.com/82098328/130841333-e2b6d2af-ee00-409d-8666-157565b79eae.png)
Before ![2021-08-25_194021_1](https://user-images.githubusercontent.com/82098328/130841443-5de055d4-6be3-4a48-8d2d-c90aecaa0495.png)
After (this PR) ![2021-08-25_193946_1](https://user-images.githubusercontent.com/82098328/130841662-361b0512-8d6b-438f-a407-a7c9de41411e.png)

I hope the original author (@dylhack) doesn't mind it 🙂

Oha-you commented 3 years ago

Gotcha, I hope it's okay to mention GitHub username instead of Matrix.

aaronraimist commented 3 years ago

Thanks!