search

aaronrenner / phx_gen_auth

An authentication system generator for Phoenix 1.5 applications.
772 stars 55 forks source link

Update registration create success flash #101

Closed jrdnull closed 3 years ago

jrdnull commented 3 years ago

Changed to match the other messages used, e.g "Account confirmed successfully."

Noticed this locally, mine would be "User created successfully." but then referred to as Account when confirming it. Makes sense tome that it should be referred to consistently.

Thanks for the project, very useful :+1:

josevalim commented 3 years ago

Which message this is inconsistent with? Notice we cannot hardcode account, those messages depend on the parameters you give to the generator.

jrdnull commented 3 years ago

https://github.com/aaronrenner/phx_gen_auth/blob/master/priv/templates/phx.gen.auth/confirmation_controller.ex#L34

There’s two in there, I’m on phone so can’t check for more easily. Could go the other way and update these to use the template variable?

josevalim commented 3 years ago

Ah, instead we need to update those too to look like this one. Good catch. :)

jrdnull commented 3 years ago

Closing in favour of https://github.com/aaronrenner/phx_gen_auth/pull/102