search

aaronrenner / phx_gen_auth

An authentication system generator for Phoenix 1.5 applications.
772 stars 55 forks source link

Wouldn't gettext integration be a good idea? #104

Closed oliverandrich closed 3 years ago

oliverandrich commented 3 years ago

Is there be any downside, if phx_gen_auth would directly use gettext? All my current projects have to support English and German and in all of them I added i18n manually after running "mix phx.gen.auth".

josevalim commented 3 years ago

It is something you can add manually, we keep the amount of markup to a minimum so it is not that much work. The reason we don't do it by default is that then everyone would have to remove it, if they don't need it, and I assume most people don't actually need it, and an option would be too complex.

oliverandrich commented 3 years ago

Thanks for the quick response. From a very English minded view, you are absolutely correct. I have to review my process because currently, I have to do about 40 manual changes in templates, controllers and so on. And I tend to forget locations. ;)

josevalim commented 3 years ago

It is not even about English per se. If I am doing a website in portuguese, I would simply rewrite the english to portuguese but without using gettext. :)