search

aarons22 / homebridge-bond

Homebridge plugin for Bond
MIT License
64 stars 31 forks source link

Shade SetPosition is restrained #256

Open y0m1g opened 11 months ago

y0m1g commented 11 months ago

Describe the bug When trying to set the position of a shade in HomeKit, the shade either fully close or fully open, regardless of the requested position.

After searching into the repo issues and code, I found that this behaviour was forced on purpose in homebridge-bond a few years ago (by this PR: https://github.com/aarons22/homebridge-bond/issues/100) in order to mitigate an erratic behaviour at the time with the Bond app/bridge that didn't support position setting, only open/close. See: https://github.com/aarons22/homebridge-bond/blob/17d21f3187a9ff86f872ea058782f601d7d1f122/src/accessories/ShadesAccessory.ts#L68 https://github.com/aarons22/homebridge-bond/blob/17d21f3187a9ff86f872ea058782f601d7d1f122/src/accessories/ShadesAccessory.ts#L40 With the minStep forced to 100, it's indeed impossible to set a position in between at the moment.

But the Bond app now fully supports a precise position setting of a shade (see screenshot below), so I think this workaround has now become a bug, and should be reverted in order to enable the positioning feature to work properly with HomeKit. Or at least, could this behaviour be switchable?

Thank you for this great plugin!

Information:

Logs N/A

IMG_9B38CC35DC9B-1

chrismerck commented 11 months ago

Indeed we now support SetPosition on most shades, both on Bond Bridge Pro and Bond Bridge. This is done by dead-reckoning if the shade technology doesn't have a discrete signal for "go to X %". For example, RTS doesn't have (to our knowledge) a discrete signal for set%, so we time the Open/Close/Hold commands. However, Rollease's ARC technology does have discrete signals for SetPosition. --- There are a few stragglers that we don't support SetPosition on, but I think the value in having external dead-reckoning is minimal at this point.

ekimneems commented 10 months ago

I have Rollease ARC, but I'm still experiencing this issue. If I set the shade to let's say 50% in HomeKit, it sort of "glitches" for a second and then simply changes the state to either fully opened or closed. Is there a setting I have to change?

If I do this in the Bond app directly to 50%, it works fine. Just not in HomeKit. Thanks!

ekimneems commented 9 months ago

@chrismerck - Any idea how I might troubleshoot my Rollease ARC only doing open/closed and not positions?