Open nwpointer opened 2 years ago
Hey! Appreciate you reaching out. One big thing is--are you planning on making breaking changes to the API again? I like the new API actually---before I had to mess with the internals to enable shadows for the terrain.
Some other thoughts
getHeight(terrainX,terrainY)
(in world coordinates?) and something like getBounds
to figure out where the terrain is. Or maybe getWorldPosition(terrainX,terrainY)
in terrain coordinates.This is great work though, so thank you! Components like three-landscape really push r3f well past what you can feasibly do with vanilla three.js
Thats awesome feedback!
Sorry about the api change :) I think the new material based api is the way forward and should be considered stable. User feedback may inform some renaming / structuring of props but maintaining backwards compatibility for that kinda thing is possible.
Documentation is something I definitely want to make improvements to for sure. I might build out a dedicated documentation site at some point but to start I think it probably needs additional examples and more rigorous type information for each of the args.
(Regarding the count difference you saw, that was an attempt to show that normal maps are not required for each texture type - ie it's ok it grass for example lacks a normal map.)
You mentioned the material was sensitive to file types - what file types were causing problems?
Applying displacement maps for individual texture types is a really interesting problem! It requires that the density of the mesh be higher in order to capture the detail in the displacement maps which can cause performance issues. Trying to figure out if I can adaptively increase the mesh density near the camera to solve this problem.
Love the pie in the sky feature, its definitely coming soon
Created issues to track those feature ideas:
Thanks again for your feedback, much appreciated!
Hope this isn't weird but just wanted to say thanks for trying out the module!
Was wondering if you had any feedback or questions about the project