aaronsgiles / ymfm

BSD-licensed Yamaha FM sound cores (OPM, OPN, OPL, and others)
BSD 3-Clause "New" or "Revised" License
259 stars 40 forks source link

Wrong 12-bit PCM decoding #13

Closed D15C0DE closed 3 years ago

D15C0DE commented 3 years ago

https://github.com/aaronsgiles/ymfm/blob/2a4e4493c7c91ac4fa590803d578f95523ff883c/src/ymfm_pcm.cpp#L563

The lower nibbles seem to be reversed. See https://github.com/ValleyBell/libvgm/commit/7a83aaebff6518ca13c243e413ea6847d732ddf1

aaronsgiles commented 3 years ago

Thanks for pointing this out! Fixed via a9c847b12f5ff8749e605bf3977dcf5fb61a4a38.