search

aaronsgiles / ymfm

BSD-licensed Yamaha FM sound cores (OPM, OPN, OPL, and others)
BSD 3-Clause "New" or "Revised" License
259 stars 40 forks source link

Pan for OPLL rhythm sound is not properly #26

Closed 110-kenichi closed 2 years ago

110-kenichi commented 2 years ago

Pan for OPLL rhythm sound is not properly. Could you please confirm?

ymfm_fm.h: around L300

Before:

if (RegisterType::OUTPUTS == 1 || m_regs.ch_output_0(choffs))

After:

if (RegisterType::OUTPUTS >= 1 || m_regs.ch_output_0(choffs))

aaronsgiles commented 2 years ago

No, sorry, your proposed change is not correct.

The OPLL chips output the FM on channel 0, and the rhythm on channel 1. This allows external wiring to control the mixing. Just because there are two outputs doesn't mean it's stereo. 😀

In this case it's really two separate mono channels, which you need to mix together if that's the way they are wired up on the system that is using them. (I expect most systems just sum them.)

110-kenichi commented 2 years ago

Ah- I see. Thank you!