search

aaronsgiles / ymfm

BSD-licensed Yamaha FM sound cores (OPM, OPN, OPL, and others)
BSD 3-Clause "New" or "Revised" License
259 stars 40 forks source link

YMF278B: Always return register 0x02 with YMF278B device ID set #46

Closed Cacodemon345 closed 1 year ago

aaronsgiles commented 1 year ago

Hmmm, if this is an ID bit specific to the ym278b, this logic would make more sense to live in ymf278b::read_data_pcm in ymfm_opl.cpp.

Cacodemon345 commented 1 year ago

It's where the external memory read is handled though, so I don't see a point here, as the device ID is already handled in the reset() function.

Cacodemon345 commented 1 year ago

Superseded by #47.