aaronsgiles / ymfm

BSD-licensed Yamaha FM sound cores (OPM, OPN, OPL, and others)
BSD 3-Clause "New" or "Revised" License
259 stars 40 forks source link

Fix virtual destructor warnings #55

Closed SupSuper closed 8 months ago

SupSuper commented 1 year ago

Compiling ymfm on MSVC currently produces the following warning:

ymfm\src\ymfm_fm.h(459,1): warning C4265: 'ymfm::fm_engine_base<ymfm::opl_registers>': class has virtual functions, but its non-trivial destructor is not virtual; instances of this class may not be destructed correctly

To ensure any classes deriving from ymfm interfaces don't leak, I added virtual destructors to all the base abstract classes.