search

aaronshaf / react-toggle

Elegant, accessible toggle component for React. Also a glorified checkbox.
http://aaronshaf.github.io/react-toggle/
MIT License
945 stars 159 forks source link

Remove the switch SVG title tags #137

Closed antoniojl closed 4 years ago

antoniojl commented 5 years ago

These SVG titles are announced by VoiceOver on Safari, but are meaningless to screenreader users, and invisible to sighted users

greenimpala commented 4 years ago

Please merge

antoniojl commented 4 years ago

Okay; shall do.

antoniojl commented 4 years ago

@tremby Could you merge this?

greenimpala commented 4 years ago

Could you release a version @tremby with the latest changes? :)

tremby commented 4 years ago

Think I'd rather leave that to @antoniojl -- I haven't done a release on this project before and don't know how it's set up. The releases page on Github says the latest is from 2016, and there aren't any tags later than that, but then NPM has much more recent releases.

I imagine it's probably just updating the version number in the package.json file and pushing, but it may then need an npm publish, for which I don't have rights.

antoniojl commented 4 years ago

And as I can't even merge PR on this project, I'm pretty sure I can't publish!

tremby commented 4 years ago

Sorry, I was too hasty with the @ autocomplete. I meant @aaronshaf.