Your article and this repository does not match

aaronte / angular-universal-firebase

https://angular-universal-firebase.firebaseapp.com/

27 stars 9 forks source link

Your article and this repository does not match #2

Closed sheikalthaf closed 6 years ago

sheikalthaf commented 6 years ago

Hi,

This repo has some slight difference between your article. please make it clear to undersatand.

Also what is public folder which deos not either?

helix46 commented 6 years ago

These are the differences angular.json

blog: "outputPath": "functions/dist/server", github: "outputPath": "functions/dist-ssr",

blog: "outputPath": "functions/dist/browser", github: "outputPath": "dist",

index.js blog: .readFileSync(path.resolve(dirname, './dist/browser/index.html'), 'utf8') github: .readFileSync(path.resolve(dirname, './dist/index.html'), 'utf8')

aaronte commented 6 years ago

Hi @sheikalthaf! Thank you for bringing up these issues. @helix46 is correct with the discrepancies and I have corrected these issues in the source code. Thanks!