EXAMPLE: Aaron Oostdijk - Working with GIT, iteration 3

aaronvark / PeerReview1819

Repo for peer review assignments for year 2 development class of 18/19

0 stars 0 forks source link

EXAMPLE: Aaron Oostdijk - Working with GIT, iteration 3 #1

Open aaronvark opened 5 years ago

aaronvark commented 5 years ago

Make sure the whole git thing works like we want it to. Special cases to take into account:

Pull Request / Review
Reference (this) issue in commits
Reference (this) issue in PR comments
Reference PR's / Commits in this issue (unnecessary)

aaronvark commented 5 years ago

Example of commenting on a pull request, focus on the following things:

Explain what you've done and how it related to your larger task
Add any additional documentation (such as UML diagrams, or other schemas)
Talk about what you want to work on next, and what kind of feedback you're looking for to figure out what to do next

Next TODO: Add a guide to how to use the git setup for students to review in class next week.

aaronvark commented 5 years ago

I've updated a guide for the git flow and pull request setup. We will probably have to separately introduce the whole git principles in class, but for the repo this should be enough?

Here's a random image to test image attachments to comments.

random