lighting model - Githubissues

aaronwalsman / splendor-render

MIT License

4 stars 0 forks source link

Closed aaronwalsman closed 3 years ago

aaronwalsman commented 3 years ago

A few things need to be cleaned up about the lighting model:

image lights have some unnecessary parameters (see other issues on image_light authorship for resolving this)
point lights, direction lights and spot lights haven't been updated in forever. Make sure they still work, and clean up the interface.
make a shader for solid-color instances. Stop using solid textures for this. THIS COULD BE PART OF WHY HUGE SCENES ARE SLOW!

aaronwalsman commented 3 years ago

Made a shader for the solid-color materials. Not the reason for slow.

aaronwalsman commented 3 years ago

Not doing spot lights for now

aaronwalsman commented 3 years ago

This has been addressed with the latest pbr pull request/branch