aaronwmorris / indi-allsky

Software to manage a Linux-based All Sky Camera.
GNU General Public License v3.0
238 stars 40 forks source link

v7.6 release - keogram/startrail broken at night? #1004

Closed StarGeezerPhil closed 1 year ago

StarGeezerPhil commented 1 year ago

@aaronwmorris upgraded straight to 7.6 after receiving the notification.

Not had chance to check through the log files etc. yet, but noticed that night time timelapses etc. seem to be broken since the update:

image

The timelapse video works absolutely fine, but the keogram and holding image for the star trail seems to be missing. Abysmal weather here so can't comment about actual star trail generation or the star trail timelapse video.

aaronwmorris commented 1 year ago

My guess is it is related to #1001 assuming you are using a detection mask. You may need to generate a new detection mask based on the new way of processing the mask.

Let me know if you need some guidance on this, it is very new.

StarGeezerPhil commented 1 year ago

Yes, using detection mask, but it's the original dimensions and matches the mask_base.png (thanks for adding this as a reference file - very useful! 👍).

aaronwmorris commented 1 year ago

You may have to try to generate the startrails/keogram again and reference the logs for errors. I did some basic testing before releasing, but only with a virtual camera. Currently, my cameras are packed up due to moving, so I have not tested as much as I would have liked.

Just some additional information about the new process. The detection mask on disk needs to be the original orientation because most of the processes using it do so before the image is altered. The exception to this is the startrails. Startrails use the detection mask and are generated from the final orientation/geometry. As part of the processing, I flip/rotate/crop the mask (using the same parameters in the config) so that it should be the same as the final orientation, but it is possible I missed some edge case.

aaronwmorris commented 1 year ago

Today I merged #1006 because I forgot to include the scaling step for the mask. I do not think this will help you, but maybe...

aaronwmorris commented 1 year ago

1008 Another fix. I will get this right eventually.

StarGeezerPhil commented 1 year ago

Brilliant @aaronwmorris - that's fixed it 👍🔥