search

aaronwmorris / indi-allsky

Software to manage a Linux-based All Sky Camera.
GNU General Public License v3.0
252 stars 42 forks source link

More Docker minifications #1624

Closed USA-RedDragon closed 2 weeks ago

USA-RedDragon commented 2 weeks ago

Capture container drops from 5.4GB to 1.8GB INDI base container drops from 3.4GB to 2.3GB

Also updates the .dockerignore to eek out a couple extra kilobytes :)

We could leverage GitHub Actions to build these and publish them here. I've been using this workflow https://github.com/USA-RedDragon/indi-allsky/blob/upstream/.github/workflows/ci.yaml but I've got a lot of magic in my reusable-workflows repo. I can unwind that to vanilla actions workflows that don't depend on a repo of mine if that's something you'd like. This would also save me from having to maintain a fork to publish these for my cluster

aaronwmorris commented 2 weeks ago

Is the TZ variable not needed? I am assuming the container automatically inherits the TZ from the host?

USA-RedDragon commented 2 weeks ago

Ahh, so typically (LinuxServer.io containers are a good example of this), Docker images ship as UTC, then users are expected to put a TZ environment variable with their timezone rather than hard-coding a TZ at build time if they want the app's time to be localized. As long as the tzdata is in the container, a runtime TZ env is all that's needed.

aaronwmorris commented 2 weeks ago

If you want to merge the ci.yaml I can definitely work on getting the GitHub actions setup. I may have to reach out for help since I do not have a great amount of familiarity with this.