search

aaronwolen / pandoc-letter

Pandoc template for writing letters in markdown
GNU General Public License v3.0
409 stars 124 forks source link

Adds link-as-notes option #11

Closed asobrien closed 7 years ago

asobrien commented 7 years ago

This PR adds link-as-notes to the example updates to the template to allow colorlinks rendering options via dvipsnames.

It turns out that links-as-notes is just a Pandoc/LaTex passthrough. This could be changed to linksasnotes but that would break with upstream. If you want to go down that road, the template would need to be updated as well.

aaronwolen commented 7 years ago

Thanks! I was not aware of the links-as-notes option but it definitely makes sense for letters.

aaronwolen commented 7 years ago

Thanks again!

asobrien commented 7 years ago

It looks like the travis build failed due to a timeout. Do you have any issues running example/letter.md with pandoc? I get an error similar to the following: https://github.com/jgm/pandoc/issues/2680

On Tue, Dec 20, 2016 at 1:21 PM, Aaron Wolen notifications@github.com wrote:

Thanks again!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/aaronwolen/pandoc-letter/pull/11#issuecomment-268317717, or mute the thread https://github.com/notifications/unsubscribe-auth/AANqmR-djRIhTls_FfeDt49ifRspi-jHks5rKByugaJpZM4LQ2bG .

aaronwolen commented 7 years ago

Yeah, it looks like your modification to the template surfaced a pre-existing bug. I'm tracking it in #12. I believe the issue is another package loading color or xcolor without the dvipsnames argument. Let me know if you have any insight.

aaronwolen commented 7 years ago

I think this is fixed in the devel branch.