aarowill / base16-alacritty

Base16 for Alacritty
http://chriskempson.com/projects/base16
MIT License
287 stars 41 forks source link

base16-eighties green and yellow are just variants of gray #2

Closed jedahan closed 6 years ago

jedahan commented 6 years ago

Wondering if this was a generation or input data issue?

aarowill commented 6 years ago

Are you sure you aren't talking about bright green/yellow? Because the bright colors are used for more base (blacks/greys/whites) colors by base16. If you're unsure, try the eighties-256 file. The bright colors match their dim counterparts so when you're expecting green or bright green you'll always get green, but you'll need to use base16-shell to get everything to work properly with programs like vim.

jedahan commented 6 years ago

ahh thanks for the clarification!

tonijarjour commented 5 years ago

So the bright green is intended to look grey in the non-256 version? Does TERM= xterm-256color have anything to do with it? 2018-11-27_08-56 .fehbg ends up very low contrast. I can live with it if it is intended and doesn't affect too many things.

tonijarjour commented 5 years ago

I'll just note that setting this: draw_bold_text_with_bright_colors: false fixes the issue.

aarowill commented 5 years ago

Yes, @tonijarjour, bright green is meant to be grey in the non-256 version. The reason draw_bold_text_with_bright_colors: false fixes this is because you end up with non-bright colors for the bold text (in your screenshot Downloads, .cache, .config, .fehbg, .gitconfig). An example from my own terminal (iTerm2, draw bold text in bright colors off, base16-summerfruit-dark theme) showing normal colors next to their bright counterparts:

image

A one-liner to show this comparison that should work on most setups:

echo " Normal   Bright"; for num in {0..7}; do echo -e "\e[37;$((40 + num))m        \e[39;49m \e[37;$((num + 100))m        \e[39;49m"; done