search

aarpon / hrm

The Huygens Remote Manager is an open-source, efficient, multi-user web-based interface to the Huygens software by Scientific Volume Imaging for parallel batch deconvolutions.
http://huygens-rm.org
Other
8 stars 9 forks source link

[BUG REPORT] Lightsheet direction has no effect on deconvolution #25

Open lacan opened 1 month ago

lacan commented 1 month ago

When defining the parameters with @RomainGuiet for a theoretical LISH PSF, we can decide on the lightheet illumination direction, for example here as From bottom

image

But whatever value we set, it gets recorded as 0.000 in the parameters template that is sent to HuCore. image

Moreover the parameter "from left|right|top|bottom" gets reset to from right each time we try to edit a previous template, meaning that it does not get recorded in HRM either...

KevinNamink commented 1 month ago

Thanks for the report.

This SPIM Direction is represented in various ways throughout the HRM and I suspect the translation utility could have broken without us noticing recently (as it has a few fallbacks that make it never return errors). I currently don't have a debugging setup for the HRM running, I hope to have time to set this up and investigate more within a week.

A link to the function using the utility I suspect (probably linked here only for my own convenience): https://github.com/aarpon/hrm/blob/e9867149c7746e49f197f275ce37f96ccfb05c61/inc/param/SpimDir.php#L63-L68

If anything this file probably is related to the issue.

KevinNamink commented 1 month ago

I found out the translation from the mysql database to the GUI and to the Huygens template both went wrong. I think I fixed it in the latest commit in the devel branch (https://github.com/aarpon/hrm/commit/130939498ae2e81ad04e1c4cb258f1b914cd3fbc). I have no clue how this ever would have worked correctly.

Can you work with this fix in the devel branch?