aarpon / hrm

The Huygens Remote Manager is an open-source, efficient, multi-user web-based interface to the Huygens software by Scientific Volume Imaging for parallel batch deconvolutions.
http://huygens-rm.org
Other
8 stars 9 forks source link

[BUG REPORT] Image file format selection only works with Chrome #5

Closed chdietrich closed 5 years ago

chdietrich commented 5 years ago

Describe the bug The dropdown "Please choose file format..." (Launch jobs) resets after selection if you use the Mozilla Firefox web browser, Google Chrome works.

To Reproduce HRM: Launch jobs -> Choose a file format

Expected behavior After selecting the file type, it should remain selected. With Chrome: https://youtu.be/1EYHoNYWXJQ

Screenshots With Firefox: https://youtu.be/zFhTUlgthdc

Environment Server-side CentOS Linux release 7.6.1810 PHP 7.2.10 Apache/2.4.6 PostgreSQL 9.2.24 HRM 3.6.0

Client-side Firefox 66.0.3 / Chrome 74.0.3729.108

carstendietrich commented 5 years ago

Hello,

the problem is a race condition, when you update the dropdown, an AJAX call is triggered in the background to save the settings in the user session. Because the page is also refreshed when the dropdown is changed, the behavior described above may occur if the page is updated before the AJAX call is evaluated.

I added a PR to address this issue. (#8)

aarpon commented 5 years ago

Thanks! Will test and merge asap.