search

aarsy / GoogleMapsAnimations

[DEPRECATED]"GoogleMapsAnimations is an awesome android library to show radar and multiple types of circular ripple effects on google map.
820 stars 176 forks source link

Reduced size of drawable to temporarily fix #5 #7

Closed mradzinski closed 7 years ago

mradzinski commented 7 years ago

Not the best solution though. Drawable size should be calculated through code based on multiple factors such as device screen size and withDistance value. But for now and until you have some time this should allow users to use the library (but not without a HUGE abuse of memory due to it's implementation).

hanuor commented 7 years ago

Can you please elaborate more on how does this help the library?

mradzinski commented 7 years ago

If you check the issue #5, the OOM exception is being caused by an excessively large drawable (1500dp) which is part of this library. By reducing the size of such drawable the OOM exception disappears. However, as I stated previously: It's not the best solution though. But, since the issue has been oppened for more than 3 months without any collaborator touching it then I believe it's time to at least patch the library to allow all users hitting the issue to use it.

aarsy commented 7 years ago

Hello Matias, Shantanu Temporary fix is good option but I also have to publish code on bintray and maven. I'm thinking to publish to bintray after removing this issue. Since I'm unavailable for few months. So it would be great for me if you guys can implement Bitmap resizing code and also LRU Cache for the bitmap so that we don't have to create bitmap again and again to show multiple same type of effects on map.

On 24 Apr 2017 10:32 am, "Matias Radzinski" notifications@github.com wrote:

If you check the issue #5 https://github.com/aarsy/GoogleMapsAnimations/issues/5, the OOM exception is being caused by an excessively large drawable (1500dp) which is part of this library. Reducing the size of such drawable the OOM exception disappears. However, as I stated previously: It's not the best solution though. But, since the issue has been oppened for more than 3 months without any collaborator touching it then I believe it's time to at least patch the library to allow all users hitting the issue to use it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/aarsy/GoogleMapsAnimations/pull/7#issuecomment-296525148, or mute the thread https://github.com/notifications/unsubscribe-auth/AMQClT98UNvQg7dhs51XejFi1q2ApW0oks5rzCzXgaJpZM4NFsNH .