search

aartaka / nx-dark-reader

Nyxt (3.0+) integration with Dark Reader.
BSD 2-Clause "Simplified" License
24 stars 3 forks source link

Startup error: The function NX-DARK-READER::FFI-BUFFER-ADD-USER-SCRIPT is undefined.. #1

Closed danrobi11 closed 2 years ago

danrobi11 commented 2 years ago

Hi. I finally have time to test your dark-reader-mode. I've followed the readme and I get this error:

Startup error: The function NX-DARK-READER::FFI-BUFFER-ADD-USER-SCRIPT is undefined..
Restarted Nyxt without init file

Nyxt version 2.2.4 OS: MXLinux based debian

aartaka commented 2 years ago

Does 589ce9d13222a645b5a18a4cf497d54204fd870b fix it?

danrobi11 commented 2 years ago

With new commit now nyxt does load the init.lisp. However when I try to enable the mode I get error: Warning: Error on separate thread: The function NYXT::FFI-BUFFER-ADD-USER-SCRIPT is undefined.

Heres my init.lisp Perhaps the issue is my init.lisp :/

aartaka commented 2 years ago

Oh wait, ffi-buffer-add-user-script is 3.0 API, it's not present in 2.2.4. That should be the reason for the error you see.

While I can re-implement the code behind ffi-buffer-add-user-script as part of nx-dark-reader, I don't see much use in re-implementation given that 3.0 release will likely happen soon.

I'll update the README to make it crystal clear that it's 3.0-only. Thanks for flagging this documentation shortcoming (which it is)!

danrobi11 commented 2 years ago

Oh wait, ffi-buffer-add-user-script is 3.0 API, it's not present in 2.2.4

Ok that makes sense. Should we close the issue?

aartaka commented 2 years ago

Yes, closing it now.