aartaka / nx-dark-reader

Nyxt (3.0+) integration with Dark Reader.
BSD 2-Clause "Simplified" License
24 stars 3 forks source link

Parity between Dark-Reader Extension #4

Open AblatedSprocket opened 1 year ago

AblatedSprocket commented 1 year ago

Should this work on all the same sites as the Firefox extension? My litmus test was https://html.duckduckgo.com/html which the Firefox extension recolors but nx-dark-reader does not.

aartaka commented 1 year ago

nx-dark-reader lacks support for dynamic theme fixes that WebExtensions-based DarkReader bundles. There are a lot (~27000 lines) of dynamic fixes, including the ones for DuckDuckGo.

I'm not sure how to support these fixes in an elegant way, especially given that:

AblatedSprocket commented 1 year ago

This extension works well on the JS version, so that works for now. I'm still getting the hang of Nyxt, but this issue would be interesting to look into when I get comfortable enough with it.