search

aartum / CA2-SIG-StandardsWG

Repo for collaboration on standards for climate action and accounting.
Apache License 2.0
2 stars 4 forks source link

Updated Ontology-ImpactAccounting.owl as per the Wiki #75

Closed sarvagyaa closed 4 months ago

sarvagyaa commented 8 months ago

Updated Ontology-ImpactAccounting.owl: Added the classes that were in the Wiki page as on Feb 7th 2024

sarvagyaa commented 8 months ago

Thank you very much for the review, Alex, and apologies for the typos. Please update the ontology in the wiki based on your discussion about the "measurement control" class. I'll make the corresponding changes, fix the positioning of the spatial and temporal reference_system classes, and correct the typos in the OWL file, and submit it for the next review.

I noticed that Christiaan made some class name changes in the wiki-ontology based on your discussion in the last meeting. I'll include these changes as well, in the OWL file.

On Mon, Feb 26, 2024 at 3:55 AM AlexIvanHoward @.***> wrote:

@.**** requested changes on this pull request.

Thanks a lot for your work, Abhi! Much appreciated. I've left a few comments and requests here and there. Will add the possible addition of a "measurement control" class to the agenda of our next group discussion - thanks for the nudge!

In Schemas/OWL/Ontology-ImpactAccounting.owl https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#discussion_r1501883192 :

Rather let 'temporal_reference_system' be a direct subclass of 'control'.

In Schemas/OWL/Ontology-ImpactAccounting.owl https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#discussion_r1501883626 :

Rather let 'spatial_reference_system' be a direct subclass of 'control'.

In Schemas/OWL/Ontology-ImpactAccounting.owl https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#discussion_r1501884280 :

 <Declaration>

- + +

Let's stick to 'control' for now. It is an interesting discussion point, though. I'll add it to the agenda for our next group meeting to discuss the possible definition of a "measurement control".

In Schemas/OWL/Ontology-ImpactAccounting.owl https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#discussion_r1501884491 :

Let's remove all references to 'measurement_statement' for now and just stick to 'control' until we've discussed with the larger group whether we should define a class like this :)

In Schemas/OWL/Ontology-ImpactAccounting.owl https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#discussion_r1501884665 :

 <Declaration>

- + +

[typo] measurement_instrument

In Schemas/OWL/Ontology-ImpactAccounting.owl https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#discussion_r1501884710 :

 </Declaration>
- +

[typo] spatial_parameter

In Schemas/OWL/Ontology-ImpactAccounting.owl https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#discussion_r1501884757 :

 </Declaration>

[typo] temporal_reference_system

In Schemas/OWL/Ontology-ImpactAccounting.owl https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#discussion_r1501884828 :

 </SubClassOf>
- - + + +

[typo] spatial_parameter

In Schemas/OWL/Ontology-ImpactAccounting.owl https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#discussion_r1501884862 :

[for consistency] claim_(n)

In Schemas/OWL/Ontology-ImpactAccounting.owl https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#discussion_r1501884884 :

[for consistency] claim_(n)

In Schemas/OWL/Ontology-ImpactAccounting.owl https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#discussion_r1501884949 :

[typo] spatial_parameter

In Schemas/OWL/Ontology-ImpactAccounting.owl https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#discussion_r1501884995 :

[typo] measurement_instrument

In Schemas/OWL/Ontology-ImpactAccounting.owl https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#discussion_r1501885023 :

[typo] temporal_reference_system

In Schemas/OWL/Ontology-ImpactAccounting.owl https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#discussion_r1501885079 :

[for consistency] claim_(n)

In Schemas/OWL/Ontology-ImpactAccounting.owl https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#discussion_r1501885150 :

[for consistency] claim_(n)

In Schemas/OWL/Ontology-ImpactAccounting.owl https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#discussion_r1501885195 :

[for consistency] claim_(n)

In Schemas/OWL/Ontology-ImpactAccounting.owl https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#discussion_r1501885223 :

[typo] temporal_reference_system

In Schemas/OWL/Ontology-ImpactAccounting.owl https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#discussion_r1501885284 :

@@ -268,7 +516,7 @@

- +

[typo] measurement_instrument

— Reply to this email directly, view it on GitHub https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#pullrequestreview-1899737470, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABA4UFWIGSJOVKJ5Y2MPMU3YVOJMZAVCNFSM6AAAAABDLQ3L26VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOJZG4ZTONBXGA . You are receiving this because you authored the thread.Message ID: @.***>

sarvagyaa commented 6 months ago

Hi, Alex. Thank you for the updates. I'll get cracking on the changes.

christiaanpauw commented 6 months ago

Hello Abhi

Just look at the spelling of #measurement_statemenr

Should it rather be #measurement_statement ?

Regards, Christiaan

On 26 Apr 2024, at 10:46, Abhi Sarvagyam @.***> wrote:

statemenr

Christiaan Pauw Tel: 044 6950 749 Cell: 082 557 4328 www.nova.org.za www.aartum.io

sarvagyaa commented 6 months ago

Hi, Christiaan. Alex already pointed that out and I fixed it, but haven't committed the corrected file yet. I guess you'd have seen the older file when you replied (10 mins ago, as per GitHub).

christiaanpauw commented 6 months ago

Thanks

On 26 Apr 2024, at 11:09, Abhi Sarvagyam @.***> wrote:

Hi, Christiaan. Alex already pointed that out and I fixed it, but haven't committed the corrected file yet. I guess you'd have seen the older file when you replied (10 mins ago, as per GitHub).

— Reply to this email directly, view it on GitHub https://github.com/aartum/CA2-SIG-StandardsWG/pull/75#issuecomment-2078968900, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJW6HUNVGYHHDGANW3YFV3Y7IKUZAVCNFSM6AAAAABDLQ3L26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZYHE3DQOJQGA. You are receiving this because you commented.

Christiaan Pauw Tel: 044 6950 749 Cell: 082 557 4328 www.nova.org.za www.aartum.io