maven central

[ArielCabib]

Hi,

Are there any plans to make this jar available in maven central?

Thanks :)

[aaryn101]

I will look into it!

[stoyicker]

I can do it if @aaryn101 allows.

[aaryn101]

Go for it!

On Sun, Apr 6, 2014 at 8:12 AM, Jorge Antonio Díaz-Benito Soriano < notifications@github.com> wrote:

I can do it if @aaryn101 https://github.com/aaryn101 allows.

Reply to this email directly or view it on GitHubhttps://github.com/aaryn101/lol4j/issues/6#issuecomment-39669347 .

[stoyicker]

@aaryn101 I've been working on it today, and I didn't know that Sonatype require javadoc in order to allow an artifact to be published to their repositories. If you want, I can just submit an empty one, but I think maybe you should document, at least, the interfaces.

[aaryn101]

Documentation has been a TODO for a while. I'll work on it this week and leave it up to you to decide whether to submit an empty one for now.

On Mon, Apr 7, 2014 at 1:46 PM, Jorge Antonio Díaz-Benito Soriano < notifications@github.com> wrote:

@aaryn101 https://github.com/aaryn101 I've been working on it today, and I didn't know that Sonatype require javadoc in order to allow an artifact to be published to their repositories. If you want, I can just submit an empty one, but I think maybe you should document, at least, the interfaces.

Reply to this email directly or view it on GitHubhttps://github.com/aaryn101/lol4j/issues/6#issuecomment-39774679 .

[stoyicker]

@aaryn101 I am facing some issues when uploading, because uploading something properly but in regards of the original developer seems to complicate things more than I expected, and I'm not having much time for it this week anyway. I can go on with it if you want on the weekend, but I'm starting to hesitate how much of a good idea this is, since there will be undesired consequences, like me appearing as the original developer of the library in mavenCentral, even if I write in the description that it is uploaded on your behalf, because it is signed with my GPG, so maybe you want to reconsider uploading it yourself when you have time. As well, I have a pull request ready to add the tasks of generating the javadoc and the source jars to the build.gradle. I will be able to perform it if you authorize my account as collaborator.

[aaryn101]

In that case, I'll take a look at uploading to maven central as soon as I get some time.

I don't see any pull requests on github, as soon as you submit one I'll look it over and accept it.

On Wed, Apr 9, 2014 at 1:29 PM, Jorge Antonio Díaz-Benito Soriano < notifications@github.com> wrote:

@aaryn101 https://github.com/aaryn101 I am facing some issues when uploading, because uploading something properly but in regards of the original developer seems to complicate things more than I expected, and I'm not having much time for it this week anyway. I can go on with it if you want on the weekend, but I'm starting to hesitate how much of a good idea this is, since there will be undesired consequences, like me appearing as the original developer of the library in mavenCentral, even if I write in the description that it is uploaded on your behalf, because it is signed with my GPG, so maybe you want to reconsider uploading it yourself when you have time. As well, I have a pull request ready to add the tasks of generating the javadoc and the source jars to the build.gradle. I will be able to perform it if you authorize my account as collaborator.

Reply to this email directly or view it on GitHubhttps://github.com/aaryn101/lol4j/issues/6#issuecomment-40006319 .

[stoyicker]

Ok I misexplained myself, sorry: as of my knowledge on this, which I must admit is not quite deep, pull requests on master are a bad idea because master is the definition of the product at all times, and therefore you only want to modify master with something that you, on your own, have checked that works, from another branch, let's call it prbranch. I have cloned the repository and created that branch locally, but since I am not appointed as collaborator in the project I don't own permissions to push the branch. If I could push the branch, I would then create the pull request to it. Anyway, the code is kind of short, so I've made a gist: https://gist.github.com/Stoyicker/10314037.

[aaryn101]

Without getting into a larger discussion of what master means and what its state should be, I’d prefer it if you simply created a pull request on github - you don’t need collaborator privileges to do this.

On Apr 9, 2014, at 2:53 PM, Jorge Antonio Díaz-Benito Soriano notifications@github.com wrote:

Ok I misexplained myself, sorry: as of my knowledge on this, which I must admit is not quite deep, pull requests on master are a bad idea because master is the definition of the product at all times, and therefore you only want to modify master with something that you, on your own, have checked that works, from another branch, let's call it prbranch. I have cloned the repository and created that branch locally, but since I am not appointed as collaborator in the project I don't own permissions to push the branch. If I could push the branch, I would then create the pull request to it. Anyway, the code is kind of short, so I've made a gist: https://gist.github.com/Stoyicker/10314037.

— Reply to this email directly or view it on GitHub.

[stoyicker]

So I've made it #9. Sorry if I was wrong with the purpose of the master branch.

[aaryn101]

Thanks! And, I think the "purpose" of master is a decision that has to be made by its owner. To me, master is simply the latest code - I use releases and tags to signify when I know that something is stable and in a release-ready state.

So, in short, you weren't really wrong - I'm just using it differently.

On Wed, Apr 9, 2014 at 4:19 PM, Jorge Antonio Díaz-Benito Soriano < notifications@github.com> wrote:

So I've made it #9 https://github.com/aaryn101/lol4j/pull/9. Sorry if I was wrong with the purpose of the master branch.

Reply to this email directly or view it on GitHubhttps://github.com/aaryn101/lol4j/issues/6#issuecomment-40023590 .