search

aarzilli / nucular

GUI toolkit for go
MIT License
906 stars 45 forks source link

Build break on macOS due to braking changes in gioui.org/op #61

Closed zdima closed 3 years ago

zdima commented 3 years ago

While installing github.com/aarzilli/gdlv on macOS the installation is failing due to build break in github.com/aarzilli/nucular due to breaking changes (ref: ae2c74ec) in gioui.org/op.

ae2c74ec — Elias Naur a month ago
op: relax Push/Pop to Save/Restore semantics

A previous change implemented save/restore semantics where a saved
state can be restored anywhere, not just in a stack-like manner.

This change similarly relaxes the exported Push/Pop operations; the next
change will rename them accordingly.

Signed-off-by: Elias Naur <mail@eliasnaur.com>
$ go get -u github.com/aarzilli/gdlv 
# github.com/aarzilli/nucular
go/pkg/mod/github.com/aarzilli/nucular@v0.0.0-20210203155122-9112adf75b4f/gio.go:357:12: undefined: op.Push
go/pkg/mod/github.com/aarzilli/nucular@v0.0.0-20210203155122-9112adf75b4f/gio.go:384:19: undefined: op.StackOp
go/pkg/mod/github.com/aarzilli/nucular@v0.0.0-20210203155122-9112adf75b4f/gio.go:394:19: undefined: op.Push
go/pkg/mod/github.com/aarzilli/nucular@v0.0.0-20210203155122-9112adf75b4f/gio.go:401:13: undefined: op.Push
go/pkg/mod/github.com/aarzilli/nucular@v0.0.0-20210203155122-9112adf75b4f/gio.go:457:13: undefined: op.Push
go/pkg/mod/github.com/aarzilli/nucular@v0.0.0-20210203155122-9112adf75b4f/gio.go:486:13: undefined: op.Push
go/pkg/mod/github.com/aarzilli/nucular@v0.0.0-20210203155122-9112adf75b4f/gio.go:503:13: undefined: op.Push
go/pkg/mod/github.com/aarzilli/nucular@v0.0.0-20210203155122-9112adf75b4f/gio.go:524:13: undefined: op.Push
go/pkg/mod/github.com/aarzilli/nucular@v0.0.0-20210203155122-9112adf75b4f/gio.go:652:11: undefined: op.Push
go/pkg/mod/github.com/aarzilli/nucular@v0.0.0-20210203155122-9112adf75b4f/gio.go:666:12: undefined: op.Push
go/pkg/mod/github.com/aarzilli/nucular@v0.0.0-20210203155122-9112adf75b4f/gio.go:666:12: too many errors

$ go version go version go1.16 darwin/arm64

aarzilli commented 3 years ago

You have to use this library with the version of gio specified in go.mod.

zdima commented 3 years ago

I am actually running a command to install https://github.com/aarzilli/gdlv from README:

go get -u github.com/aarzilli/gdlv

Should I open issue with github.com/aarzilli/gdlv?

aarzilli commented 3 years ago

I'm going to update the documentation of gdlv soon, if you are on 1.16 you can just do go install github.com/aarzilli/gdlv@latest, cloning and using go install also works. Eventually I will also update nucular to the latest version of gio.

aarzilli commented 3 years ago

PS. I have update the install instructions for gdlv, sorry for the inconvenience.