[V3] Fix invariant for AASd-129

aas-core-works / aas-core-meta

Provide formalized meta-models for Asset Administration Shell (AAS).

Other

9 stars 3 forks source link

[V3] Fix invariant for AASd-129 #250

Closed mristin closed 1 year ago

mristin commented 1 year ago

We got the logic wrong in #249. Namely, when a submodel element has no qualifiers, the predicate are still satisfied and imply that the submodel has to be a template.

This patch (hopefully) solves the issue. We tested the logic preliminary on aas-core3.0-testgen and it seems to work.

mristin commented 1 year ago

@s-heppner @zrgt Please do not mind my comment on #249. The change was incorrect.

Please review this pull request whenever you find time.

zrgt commented 1 year ago

Yes, the logic of the invariant was wrong. Problem occures not only when a submodel element has no qualifiers, but also if submodel.kind is Instance, then the invariant returns True anyway without further checking.

As far as I can see the patch solves the issue.