Closed mristin closed 1 year ago
Removing this invariant was the right choice. The implementation had nothing to do with the text.
The actual invariant is that of AASc-3a-003 in the spec, with the same exact wording as in the docstring here.
The meaning of this constraint is the following: "In an Value_reference_pair
, in which the Value_reference_pair.value_ID
is a Reference
to a Concept_description
, in which the Concept_description.embedded_data_specifications
is a Data_specification_IEC_61360
, the Data_specification_IEC_61360.value
cannot be None
."
Still, this constraint is not entirely clear to us, considering Concept_description.embedded_data_specifications
is a List of Data_specification
s, yet the constraint speaks in singular. Also, the formulation is very confusing.
Nevertheless, this constraint cannot be implemented as invariant, since we cannot resolve references. Therefore, now the only thing left is to document our procedure.
The following invariant seems off:
https://github.com/aas-core-works/aas-core-meta/blob/d46eff4d84545ba7cc153f83478e0a13533ad050/aas_core_meta/v3.py#L4283