[V3] Fix inclusive OR in AASd-131

aas-core-works / aas-core-meta

Provide formalized meta-models for Asset Administration Shell (AAS).

Other

10 stars 3 forks source link

[V3] Fix inclusive OR in AASd-131 #280

Closed mristin closed 1 year ago

mristin commented 1 year ago

We misinterpreted the text of the constraint AASd-131. We understood "Either ... or ..." as an exclusive OR, whereas it should be understood as inclusive OR.

Fixes #278.

mristin commented 1 year ago

@sebbader-sap @chborntraeger please review at your next convenience.

(I couldn't add you as reviewers directly in GitHub since GitHub limits that feature only for team members.)

chborntraeger commented 1 year ago

Hi Marko,

unfortunately I'm not really fit in Python ;) but looks good and in my test script all cases were good

s-heppner commented 1 year ago

Looks good to me

mristin commented 1 year ago

(@sebbader-sap @sebbader just a kind reminder. I'd be able to work on the propagation to SDKs this Wed, so, if possible, let'stry to merge this in till then.)