search

aas-core-works / aas-core-meta

Provide formalized meta-models for Asset Administration Shell (AAS).
Other
9 stars 3 forks source link

[V3] Fix AASc-3a-010-for-NAND #281

Closed mristin closed 1 year ago

mristin commented 1 year ago

We misinterpreted the text of the constraint AASc-3a-010. It does not mean an exclusive OR, but rather a NAND. Both value and value_list should not be specified.

This patch adjusts the code to fit the text, to the best of our understanding.

We also remove the redundant part of the constraint related to the length of value_reference_pairs of value_list as that is already verified in the class Value_list.

Fixes #279.

mristin commented 1 year ago

@sebbader-sap @chborntraeger please review at your next convenience.

(I couldn't add you as reviewers directly in GitHub since GitHub limits that feature only for team members.)

chborntraeger commented 1 year ago

Hi Marko,

unfortunately I'm not really fit in Python ;) but looks good and in my test script all cases were good

mristin commented 1 year ago

(@sebbader @sebbader-sap just a kind reminder)