search

aas-core-works / aas-core-meta

Provide formalized meta-models for Asset Administration Shell (AAS).
Other
9 stars 3 forks source link

Constraint AASd-120 is missing #294

Closed BirgitBoss closed 8 months ago

BirgitBoss commented 10 months ago

Constraint AASd-120: idShort of submodel elements being a direct child of a SubmodelElementList shall not be specified.

is not listed in https://aas-core-works.github.io/aas-core-meta/v3/index.html

Source: https://github.com/admin-shell-io/aas-specs-api/issues/112

Additionally https://github.com/admin-shell-io/aas-specs-api/issues/112 is asking for validation of AASd-117 and AASd-120. I assume these two constraints belong to those we do not validate/that cannot be validated?

mristin commented 10 months ago

@BirgitBoss thanks for reporting the issue!

The invariant is indeed specified: https://aas-core-works.github.io/aas-core-meta/v3/SubmodelElementList.html#invariants

However, we mistakenly omitted to add it to the appropriate class description.

@s-heppner could you please have a look where the appropriate constraint should be added in the docstrings in aas-core-meta?

Additionally https://github.com/admin-shell-io/aas-specs-api/issues/112 is asking for validation of AASd-117 and AASd-120. I assume these two constraints belong to those we do not validate/that cannot be validated?

As a matter of fact, both AASd-120 and AASd-117 are validated. Please see: https://github.com/aas-core-works/aas-core-meta/blob/main/aas_core_meta/v3.py and search for AASd-120 and AASd-117.

s-heppner commented 10 months ago

I've added the missing documentation of AASd-120 in #295

AASd-117 is indeed implemented and documented here.

mristin commented 9 months ago

@s-heppner just a status update from my side: I'm finishing the c++ generator, and afterwards I'll merge in all the pending aas-core-meta and aas-core-testgen PRs.