search

aas-core-works / aas-core-meta

Provide formalized meta-models for Asset Administration Shell (AAS).
Other
9 stars 3 forks source link

[V3] Update to v3.0.1 #334

Open s-heppner opened 2 months ago

s-heppner commented 2 months ago

This PR collects all changes for v3.0.1 of the specification.

Here's a list of the changes. For easier reviewing, you can refer to the mentioned PRs. Please forgive the unconventional use of PRs, but I need to generate the new schema files asap.

Revert Optional in Embedded_data_specification

(See #329)

In #328, we made the attribute data_specification in class Embedded_data_specification optional, since that is what we thought the specification said (See also the discussion in #326)

However, this was a bug in the specification, which is fixed in v3.0.1 of the specification. We therefore revert these changes.

Fixes #326

Remove matches_RFC_8089_path invariant from Path_type

(See #333)

Currently, the regex for Path type is non-compliant to the specification v3.0.1, as it does not allow for AASX packages to be written.

As a temporary bugfix in v3.0.1, it was decided to remove the invariant check, as changing the pattern would result in a breaking change. This is of course no final solution, there will be a better fix for version 3.1.

See also admin-shell-io/aas-specs#299

s-heppner commented 1 week ago

With the release of the Specification of the AAS Part 1 v3.0.1 this PR is now ready to be merged.

mristin commented 1 week ago

Please wait, there is this issue pending: https://github.com/aas-core-works/aas-core3.0-python/issues/37

mristin commented 3 days ago

Just FYI: we have to wait for the issue https://github.com/aas-core-works/aas-core3.0-python/issues/32 to be fixed in Java SDK, and then I will be able to fix https://github.com/aas-core-works/aas-core3.0-python/issues/37 in this repository (and propagate the changes to SDKs).

Then we can finally re-check this pull request, merge it in and propagate it to all the SDKs etc.