aas-core-works / aas-core3.0-csharp

Manipulate, verify and de/serialize asset administration shells in C#.
Other
7 stars 1 forks source link

Wrong attributes on AssetAdministrationShell class? #17

Closed Pabzt closed 1 year ago

Pabzt commented 1 year ago

Hi,

according to the current version of the spec.: https://industrialdigitaltwin.org/wp-content/uploads/2023/05/V3.0_Specification_AAS_Part1_Metamodel.pdf (page: 59)

the AssetAdministrationShell class only has the following attributes:

and inherits from: Identifiable; HasDataSpecification.

While the core works AssetAdministrationShell class has the same attributes there are also other ones like:

Both state to be version 3.0. Am I missing something?

mristin commented 1 year ago

Hi @Pabzt, We do not implement inheritance to avoid problems with diamond inheritances and decorators. The smaller set of properties are specified in the respective interfaces.

The properties that you have listed are inherited from parent classes. We thus concretize all the concrete classes, and make them implement the interfaces.

Note that the properties are actually private (inlined by c# compiler), while only the getters and setters are public.