The 'check' task is introduced by LifecycleBasePlugin

aaschmid / gradle-cpd-plugin

Gradle plugin to find duplicate code using PMDs copy/paste detection (= CPD).

Apache License 2.0

95 stars 12 forks source link

The 'check' task is introduced by LifecycleBasePlugin #31

Closed larsgrefer closed 5 years ago

larsgrefer commented 5 years ago

The 'check' task is not added by the JavaBasePlugin, but by LifecycleBasePlugin. Therefore the latter should be used, to detect its presence.

aaschmid commented 5 years ago

@larsgrefer: Thanks for this improvement. With which versions have you tested this change?

larsgrefer commented 5 years ago

I'll have a look at the failing test on travis.

coveralls commented 5 years ago

Coverage remained the same at 85.714% when pulling cbb488d29dba4fca837c307db5abbfd1daaef06e on larsgrefer:feature/LifecycleBasePlugin into 4f0cda80e60f686612e482101652a3e3d2fa74ba on aaschmid:master.

aaschmid commented 5 years ago

Thanks @larsgrefer, I will have a deeper look :-)

Are these changes urgent for you in any case?