Use lombok to avoid boilerplate code

aaschmid / gradle-cpd-plugin

Gradle plugin to find duplicate code using PMDs copy/paste detection (= CPD).

Apache License 2.0

96 stars 12 forks source link

Use lombok to avoid boilerplate code #42

Closed larsgrefer closed 5 years ago

coveralls commented 5 years ago

Coverage decreased (-1.4%) to 84.746% when pulling 536aff5d83af71903a38831790a44defc5cb798b on larsgrefer:feature/lombok into c6eec4917605a91edab1a425696631a7db435a9e on aaschmid:master.

coveralls commented 5 years ago

Coverage decreased (-0.9%) to 84.502% when pulling b608d29a7850f99af7a75fb5710b1644384edee1 on larsgrefer:feature/lombok into 1cf1b79e0f7fa6eddd5d135a359c90e37b5e90fe on aaschmid:master.

aaschmid commented 5 years ago

I am actually not the biggest fan of lombok and this project the fields are not changing very often such that i do not see the benefit compared to the tradeoffs.

Are you fine with this @larsgrefer?

larsgrefer commented 5 years ago

As you like it. This was just a suggestions.

But I'm curious: What are the tradeoffs you're talking about?

aaschmid commented 5 years ago

Here are my tradeoffs. Disclaimer: Maybe they are outdated and if so, please tell me ;-)

Development:

More complex refactoring
Order of declaration is used for method signatures
graps deep into the source code
IDE support not so good
renaming is more complex

Environment:

versioning different to standards
Jacoco/Cobertura/Sonar and so on cannot handle generated code
javadoc can only be generated from "delomboked" stuff

Also interesting is this blogpost: https://medium.com/@vgonzalo/dont-use-lombok-672418daa819. It has some interesting points...

By the way, another approach is https://immutables.github.io/

larsgrefer commented 5 years ago

I'm using IntelliJ IDEA as IDE and have absolutely no problems with refactoring/renamings or IDE support in general. It's all handled transparently.

JaCoCo intentionally ignores all the code generated by Lombok.

The Gradle Plugin I've used here (io.freefair.lombok) also reconfigures the javadoc Task in order to use the delomboked-sources.