search

aashan10 / magento2-link-guest-order

A Magento 2 module that links guest orders to customer account if a customer account with order email exists.
MIT License
1 stars 1 forks source link

Should still work? #4

Closed jorgb90 closed 4 months ago

jorgb90 commented 1 year ago

Few years further now, should this still be compatible?

rachanajay commented 8 months ago

Mostly yes, although filtering guest order data in admin grid doesn't work anymore.

sumeetmagento commented 5 months ago

it is not working with Filter,any code to fixing this ?

rachanajay commented 5 months ago

Yes, I have fixed it. I'll try to send the pr for the code changes soon @sumeetmagento

sumeetmagento commented 5 months ago

@rachanajay is it possible now? or you will just share code here

sumeetmagento commented 5 months ago

@rachanajay any update please ?

We are getting this issue when we filter via order id - main.CRITICAL: PDOException: SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'increment_id' in where clause is ambiguous in /vendor/magento/framework/DB/Statement/Pdo/Mysql.php:90

aashan10 commented 4 months ago

@sumeetmagento @rachanajay Thank you for using this project. I used to work with magento a while back and I created this for my own use case, but lately I haven't been using it so much. I'll try to update this to support the latest magento 2 version when I have time and if you already have worked on this, feel free to send a pull request. Sorry for the delayed response.

aashan10 commented 4 months ago

@jorgb90 To be honest here, I didn't know anyone else was using this module. I created it a while back when I was still working on Magento 2. I even missed the notification for this issue among a thousand github spam emails I guess. But if you guys are actively using it, I'd be happy to keep this project running. I'll update it when I have time, probably over the weekend sometimes.

aashan10 commented 4 months ago

Also, it'd be really helpful for me to work on it if someone could open up a new issue mentioning the exact problem. This issue feels more like a discussion than an issue that I could get some information on. Please include steps to reproduce the mentioned problem with filters.

@sumeetmagento maybe you could do that?

aashan10 commented 4 months ago

NVM, I found the issue myself and updated the package. https://github.com/aashan10/magento2-link-guest-order/commit/f959322df7c669872a058c5f6971d926441945ba

@sumeetmagento I've published a new release with this bugfix which should solve your problem. Please update the version to 1.0.5 in your composer.json