search

aashishksahu / SafeSpace

A safe place for your valuable information
GNU General Public License v3.0
180 stars 11 forks source link

Doesn't detect rooted phone #18

Closed Klimmbimmel closed 11 months ago

Klimmbimmel commented 1 year ago

I've read in #5 that the app should be self-blocking if the phone is rooted. But this does not happen for me. (but a toast notification from Magisk pops up, that no root access is granted, so maybe the request for root is posed wrongly.)

Android 10 Magisk current version from F-Droid, 1.1.5

aashishksahu commented 1 year ago

Hi @Klimmbimmel I'd like to gather more information. Can you browse root files on your phone and is magisk hiding root status from the app?

Although there's a root check but it is not always 100% reliable. In order for it to make it more reliable, I'll have to add google safetynet check and I kinda don't like the word google.

Also the app doesn't have strict root restriction because people who root know what they are doing and the risks involved, so I have some level of restriction but it's not too restrictive.

Happy to help :)

aashishksahu commented 11 months ago

Closing as no activity.

Klimmbimmel commented 11 months ago

Magisk is not hiding root status, but I have nothing related to Google installed except OpenGapps Pico

aashishksahu commented 11 months ago

Well, magisk is definitely doing something, and I haven't added any strict restrictions.

Klimmbimmel commented 11 months ago

v26.3 (26300) i am using SafeSpace can ask magisk for root, and if i select something like "yes, allow root access", safeSpace might see it the way you designed it. Also, i can go over the magisk menu -> SuperUser -> set root access. I get the toast notification that SafeSpace was granted root rights by magisk, but still it doesnt show the root warning

aashishksahu commented 11 months ago

@Klimmbimmel as I said before, I haven't added any checks for magisk, so the way it grants root access is something I need to research. Also, if you'd like to check the code and provide some suggestions, it would be very helpful. It's a good time I ask for help, lol.