search

aashishksahu / SafeSpace

A safe place for your valuable information
GNU General Public License v3.0
144 stars 9 forks source link

Add progress notifications for file import & export #45

Closed starry-shivam closed 3 months ago

starry-shivam commented 4 months ago

Hi! First off, thank you for creating such a useful application. I've been using it for a while now. However, one thing that used to bother me was the lack of any progress indicator when importing large files. So, in this pull request, I've added a notification with a progress bar. This will allow the user to see the progress of file import and export.

https://github.com/aashishksahu/SafeSpace/assets/58552395/7412c1b3-91b0-4d30-b2d1-76d8250b5a82

aashishksahu commented 4 months ago

Thanks man!! I've been banging my head with progress bars for a long time, for some reason I couldn't get them to work. Progress in notification is a great idea. I'll merge it in the next release, great job, this looks good! Keep Contributing!! :)

starry-shivam commented 4 months ago

I've pushed a fix for this now. Everything else looks fine to me. Thanks!

aashishksahu commented 3 months ago

Hi @starry-shivam, I finally got some time to review your PR, everything seems fine except the naming at two places, I've added comments. Please check those and make changes accordingly. Thanks :)

starry-shivam commented 3 months ago

Hi @starry-shivam, I finally got some time to review your PR, everything seems fine except the naming at two places, I've added comments. Please check those and make changes accordingly. Thanks :)

Yeah, thanks for the heads-up. I've pushed a fix for that right now.

aashishksahu commented 3 months ago

Hi @starry-shivam, I finally got some time to review your PR, everything seems fine except the naming at two places, I've added comments. Please check those and make changes accordingly. Thanks :)

Yeah, thanks for the heads-up. I've pushed a fix for that right now.

That was really fast 👌