search

aashutoshrathi / git-stalk-cli

A CLI tool for keeping an eye on contributions of peers (Python Package)
https://pypi.org/project/git-stalk/
MIT License
43 stars 38 forks source link

Remove Today from default format and insert date instead #38

Open aashutoshrathi opened 6 years ago

aashutoshrathi commented 6 years ago

Default format of output in console contains Today which is now irrelevant as we provide date arguements

ammarmallik commented 6 years ago

@aashutoshranthi please provide some description. I wanna do this task.

GenericStudent commented 6 years ago

@ammarmallik, The printed output is hard coded to say things such as: {} have made {} public contribution(s) today. line 141 {} have done {} other public activit(y/ies) today. line 157 {} have starred {} repo(s) today. line 176

The logic has been modified with the addition of --date parameter, so these print statements need to reflect the date value (args['date']) which should be passed into the function calls between lines 298 and 307.

Hopefully that clarifies it a little more

ammarmallik commented 6 years ago

Yes, Thanks. I'll make a pull request with its fix.

ammarmallik commented 6 years ago

I have completed the dev work. Please merge this pull request #31 before applying these changes. This is the pull request #44.