search

aassif / pvr.freebox

Kodi + Freebox TV
MIT License
64 stars 24 forks source link

Compile fails with - but does not override - with 22.1.0-Piers #126

Open heitbaum opened 3 months ago

heitbaum commented 3 months ago 
BUILD      pvr.freebox (target)
    TOOLCHAIN      cmake (auto-detect)
Executing (target): cmake -GNinja -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_TOOLCHAIN_FILE=/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/etc/cmake-x86_64-libreelec-linux-gnu.conf -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Release /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/pvr.freebox-22.1.0-Piers
-- The C compiler identification is GNU 14.2.0
-- The CXX compiler identification is GNU 14.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/bin/x86_64-libreelec-linux-gnu-g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Checking to see if CXX compiler accepts flag -flto
-- Checking to see if CXX compiler accepts flag -flto - yes
-- Found OpenSSL: /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/lib/libcrypto.so (found version "3.3.1")
-- Found ZLIB: /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/lib/libz.so (found version "1.3.1")
-- Found nlohmann_json: /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include
-- FREEBOX_VERSION=21.0.0
-- FREEBOX_VERSION=21.0.0
-- Addon dependency check ...
--  - Added API usage definition: ADDON_GLOBAL_VERSION_MAIN_USED (Version: "2.0.2", Min. Version: "2.0.0")
--  - Added API usage definition: ADDON_GLOBAL_VERSION_GENERAL_USED (Version: "1.0.5", Min. Version: "1.0.4")
--  - Added API usage definition: ADDON_GLOBAL_VERSION_GUI_USED (Version: "5.15.0", Min. Version: "5.15.0")
--  - Added API usage definition: ADDON_GLOBAL_VERSION_FILESYSTEM_USED (Version: "1.1.8", Min. Version: "1.1.7")
--  - Added API usage definition: ADDON_GLOBAL_VERSION_NETWORK_USED (Version: "1.0.4", Min. Version: "1.0.0")
--  - Added API usage definition: ADDON_GLOBAL_VERSION_TOOLS_USED (Version: "1.0.4", Min. Version: "1.0.0")
--  - Added API usage definition: ADDON_INSTANCE_VERSION_PVR_USED (Version: "9.0.0", Min. Version: "9.0.0")
-- Configuring done (2.3s)
-- Generating done (0.0s)
-- Build files have been written to: /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/pvr.freebox-22.1.0-Piers/.x86_64-libreelec-linux-gnu
Executing (target): ninja 
[1/3] Building CXX object CMakeFiles/pvr.freebox.dir/src/Freebox.cpp.o
FAILED: CMakeFiles/pvr.freebox.dir/src/Freebox.cpp.o 
/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/bin/x86_64-libreelec-linux-gnu-g++ -DADDON_GLOBAL_VERSION_FILESYSTEM_USED -DADDON_GLOBAL_VERSION_GENERAL_USED -DADDON_GLOBAL_VERSION_GUI_USED -DADDON_GLOBAL_VERSION_MAIN_USED -DADDON_GLOBAL_VERSION_NETWORK_USED -DADDON_GLOBAL_VERSION_TOOLS_USED -DADDON_INSTANCE_VERSION_PVR_USED -DBUILD_KODI_ADDON -DFREEBOX_VERSION=21.0.0 -Dpvr_freebox_EXPORTS  -march=x86-64-v3 -Wall -pipe  -O2 -fomit-frame-pointer -DNDEBUG -std=c++20 -fPIC   -DTARGET_POSIX -DTARGET_LINUX -D_GNU_SOURCE -DHAVE_LINUX_UDMABUF=1 -DHAVE_LINUX_DMA_HEAP=1 -DHAVE_LINUX_DMA_BUF=1 -DHAVE_MKOSTEMP=1 -DHAVE_LINUX_MEMFD=1 -DHAVE_STATX=1 -DHAVE_SSE=1 -DHAVE_SSE2=1 -DHAVE_SSE3=1 -DHAVE_SSSE3=1 -DHAVE_SSE4_1=1 -MD -MT CMakeFiles/pvr.freebox.dir/src/Freebox.cpp.o -MF CMakeFiles/pvr.freebox.dir/src/Freebox.cpp.o.d -o CMakeFiles/pvr.freebox.dir/src/Freebox.cpp.o -c /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/pvr.freebox-22.1.0-Piers/src/Freebox.cpp
In file included from ../src/Freebox.cpp:39:
../src/Freebox.h:359:15: error: 'PVR_ERROR Freebox::GetChannelStreamProperties(const kodi::addon::PVRChannel&, std::vector<kodi::addon::PVRStreamProperty>&)' marked 'override', but does not override
  359 |     PVR_ERROR GetChannelStreamProperties(const kodi::addon::PVRChannel &, std::vector<kodi::addon::PVRStreamProperty> &) override;
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~
    PVR_ERROR GetEPGForChannel(int, time_t, time_t, kodi::addon::PVREPGTagsResultSet &) override;
heitbaum commented 3 months ago

Removing override from 359 does allow the compile to complete.

ksooo commented 3 months ago

You are building against wrong Kodi addon SDK it seems, @heitbaum You need latest Kodi master to compile this addon for Piers.

EDIT: seems to be the other way round. You are building outdated addon sources against latest Kodi master.

ksooo commented 3 months ago

FREEBOX_VERSION=21.0.0 Added API usage definition: ADDON_INSTANCE_VERSION_PVR_USED (Version: "9.0.0", Min. Version: "9.0.0")

You need at least 21.1.0 - 21.0.0 is compatible only up to API 8.4.0

heitbaum commented 3 months ago

@ksooo something is still weird then - as the 21.1.0 tag is being requested from github. is it just not tagged right?

docker@8266c28fde1c:/var/media/DATA/home-rudi/LibreELEC.tv$ s/get pvr.freebox
GET      pvr.freebox (archive)
--2024-08-20 05:18:19--  https://github.com/aassif/pvr.freebox/archive/22.1.0-Piers.tar.gz
Resolving github.com (github.com)... 4.237.22.38
Connecting to github.com (github.com)|4.237.22.38|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/aassif/pvr.freebox/tar.gz/refs/tags/22.1.0-Piers [following]
--2024-08-20 05:18:19--  https://codeload.github.com/aassif/pvr.freebox/tar.gz/refs/tags/22.1.0-Piers
Resolving codeload.github.com (codeload.github.com)... 4.237.22.35
Connecting to codeload.github.com (codeload.github.com)|4.237.22.35|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/x-gzip]
Saving to: '/var/media/DATA/home-rudi/LibreELEC.tv/sources/pvr.freebox/pvr.freebox-22.1.0-Piers.tar.gz'

/var/media/DATA/home-rudi/Lib     [ <=>                                              ]  35.68K  --.-KB/s    in 0.02s

2024-08-20 05:18:20 (2.12 MB/s) - '/var/media/DATA/home-rudi/LibreELEC.tv/sources/pvr.freebox/pvr.freebox-22.1.0-Piers.tar.gz' saved [36535]

    INFO      Calculated checksum: 71f3ee105d1d5ce6e30af4c7d3302729b34e5cd0b098022546e04124b8460465
docker@8266c28fde1c:/var/media/DATA/home-rudi/LibreELEC.tv$ s/build pvr.freebox
docker@8266c28fde1c:/var/media/DATA/home-rudi/LibreELEC.tv$ s/clean pvr.freebox
CLEAN      pvr.freebox
    *      Removing /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/pvr.freebox-22.1.0-Piers ...
    *      Removing /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/install_pkg/pvr.freebox-22.1.0-Piers ...
    *      Removing /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/qa_checks/pvr.freebox-* ...
docker@8266c28fde1c:/var/media/DATA/home-rudi/LibreELEC.tv$ s/build pvr.freebox
UNPACK      pvr.freebox
BUILD      pvr.freebox (target)
    TOOLCHAIN      cmake (auto-detect)
Executing (target): cmake -GNinja -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_TOOLCHAIN_FILE=/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/etc/cmake-x86_64-libreelec-linux-gnu.conf -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Release /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/pvr.freebox-22.1.0-Piers
-- The C compiler identification is GNU 14.2.0
-- The CXX compiler identification is GNU 14.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/bin/x86_64-libreelec-linux-gnu-g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Checking to see if CXX compiler accepts flag -flto
-- Checking to see if CXX compiler accepts flag -flto - yes
-- Found OpenSSL: /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/lib/libcrypto.so (found version "3.3.1")
-- Found ZLIB: /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/lib/libz.so (found version "1.3.1")
-- Found nlohmann_json: /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include
-- FREEBOX_VERSION=21.0.0
-- FREEBOX_VERSION=21.0.0
-- Addon dependency check ...
--  - Added API usage definition: ADDON_GLOBAL_VERSION_MAIN_USED (Version: "2.0.2", Min. Version: "2.0.0")
--  - Added API usage definition: ADDON_GLOBAL_VERSION_GENERAL_USED (Version: "1.0.5", Min. Version: "1.0.4")
--  - Added API usage definition: ADDON_GLOBAL_VERSION_GUI_USED (Version: "5.15.0", Min. Version: "5.15.0")
--  - Added API usage definition: ADDON_GLOBAL_VERSION_FILESYSTEM_USED (Version: "1.1.8", Min. Version: "1.1.7")
--  - Added API usage definition: ADDON_GLOBAL_VERSION_NETWORK_USED (Version: "1.0.4", Min. Version: "1.0.0")
--  - Added API usage definition: ADDON_GLOBAL_VERSION_TOOLS_USED (Version: "1.0.4", Min. Version: "1.0.0")
--  - Added API usage definition: ADDON_INSTANCE_VERSION_PVR_USED (Version: "9.0.0", Min. Version: "9.0.0")
-- Configuring done (1.2s)
-- Generating done (0.0s)
-- Build files have been written to: /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/pvr.freebox-22.1.0-Piers/.x86_64-libreelec-linux-gnu
ksooo commented 3 months ago

is it just not tagged right?

OMG, you are right. My bad.

ksooo commented 3 months ago

@heitbaum fyi: https://github.com/aassif/pvr.freebox/releases/tag/22.1.0.1-Piers

heitbaum commented 3 months ago

@heitbaum fyi: https://github.com/aassif/pvr.freebox/releases/tag/22.1.0.1-Piers

perfect - fixed.

ksooo commented 3 months ago

@aassif could you please delete the broken tag 22.1.0-Piers? I seems I do not have the permission to do this myself. And to avoid such mistakes in the future it would really help if you switch default branch of this repo to "Piers".