remove force to C++17 - Githubissues

aassif / pvr.freebox

Kodi + Freebox TV

MIT License

64 stars 24 forks source link

remove force to C++17 #30

Closed AlwinEsch closed 4 years ago

AlwinEsch commented 4 years ago

Think this not needed and breaks the Raspberry build of the addon?

Was added by this commit https://github.com/aassif/pvr.freebox/commit/b30d1c2f63a07898941c8e6783ad890679429808#diff-af3b638bc2a3e6c650974192a53c7291R33 where also a stdc++fs was on libs (whould make sense then). But was removed on https://github.com/aassif/pvr.freebox/commit/d6e2b498c2efe7edbe94388ec2ffa62526547f20#diff-af3b638bc2a3e6c650974192a53c7291L21 and seen nothing in code where C++17 is needed.

By remove the Raspberry build was fixed.

Not sure if needed for future, but thought to ask with it.

AlwinEsch commented 4 years ago

If Ok then I can also create a backport request to Leia.

aassif commented 4 years ago

Fine by me :) And a backport to Leia would be great!