Please stop using the same rev for Matrix and Leia releases

aassif / pvr.freebox

Kodi + Freebox TV

MIT License

64 stars 24 forks source link

Please stop using the same rev for Matrix and Leia releases #33

Closed MilhouseVH closed 4 years ago

MilhouseVH commented 4 years ago

Thank you.

aassif commented 4 years ago

I'm sorry. What do you mean? They should differ. Don't they?

MilhouseVH commented 4 years ago

Further to this, when the 2.0.1-Leia release is downloaded, the source code is actually the 2.2.0-Matrix release. So you may need to re-tag the latest releases correctly.

I'm sorry. What do you mean? They should differ. Don't they?

See here:

You've used the same rev 7fb6d449214cf9366049a667ec9bd6d5c3216594 for both 2.2.0-Matrix and 2.0.1-Leia.

MilhouseVH commented 4 years ago

I'm guessing your 2.0.1-Leia tag should be using rev 40c05be07720fbbd1cba8404e5edfa26298cb3de or possibly rev 267eff873a7c366c6f929deafac506136a4171c9, but definitely NOT 7fb6d449214cf9366049a667ec9bd6d5c3216594 as that is 2.2.0-Matrix. :smile:

aassif commented 4 years ago

I'll try to fix this mess.

MilhouseVH commented 4 years ago

Thanks!

MilhouseVH commented 4 years ago

Yes that looks good now, thanks!