search

aassif / pvr.freebox

Kodi + Freebox TV
MIT License
64 stars 24 forks source link

[Matrix] change to new C++ PVR interface way #53

Closed AlwinEsch closed 4 years ago

AlwinEsch commented 4 years ago

Changes related to xbmc/xbmc#16485.

This make the addon to the new C++ addon interface. With missing backend not runtime tested!

About them I looked to hold his code style and hope stil correct.

Also are them set to handle one instance way. If more as one backend can be possible for them, it need the CAddonBase and CInstancePVRClient separated (this currently not supported in Kodi, but addon interface prepared for it). If backend only one time possible then this the better way for me.

Hope my changes are mostly OK for you :smile:

aassif commented 4 years ago

Impressive! Couldn't have done any better! Thank you!

AlwinEsch commented 4 years ago

Performed update of request, the request on Kodi itself is finished and only need now all addons a bit recheck and small changes. For here:

aassif commented 4 years ago

I recently discovered GetAddonInfo which I was about to use but the #define is way better! Thanks!

aassif commented 4 years ago

Ready to merge.

AlwinEsch commented 4 years ago

The request in Kodi is in, after the Ubuntu package build of them is ready can it in here too (tomorrow).

Why comes here no AppVeyor, Travis and Jenkins build?

aassif commented 4 years ago

Why comes here no AppVeyor, Travis and Jenkins build?

What do you mean?

AlwinEsch commented 4 years ago

Has not seen any test builds here e.g. like here https://github.com/flubshi/pvr.waipu/pull/76 (the "All checks have passed")

Edit: Also not sure if then after release a from Jenkins created binary becomes publicated.