search

aassif / pvr.freebox

Kodi + Freebox TV
MIT License
64 stars 24 forks source link

[openssl] bypass android conf NDK detection #98

Closed fuzzard closed 1 year ago

fuzzard commented 1 year ago

Looks to work.

This is how i would fix your openssl issue. Rather than rely on the generic detections of NDK info in openssl, we know all that info already. So just patch to use our data for the relevant flags.

i do custom config files for Kodi apple platforms and its use of openssl. its just easier than trying to work within openssl's definitions.

I would advise you have someone test the resulting android build artifacts to confirm things are ok.

aassif commented 1 year ago

Thanks a lot!

We should know soon if these builds are OK but I'm now faced with a last issue: osx-arm64. Could you please take a look?

fuzzard commented 1 year ago

I wouldn't worry about osx-arm yet. It's not an officially supported platform, so it's fine to fail. I don't have time to fix it right now, but I've gone through most add-ons PRing those changes in the past. I'll get around to it eventually

aassif commented 1 year ago

Currently, nothing is uploaded to the mirrors anymore. Probably because all the builds are failing.

Rather than disabling osx-arm64 in platforms.txt, I tried to fix it. Curiously, one build passed but, once I had already merged it, subsequent builds failed. What's happening? Is it due to cmake caching something?

aassif commented 1 year ago

I know you are busy but I think I fixed it: I shouldn't have been so cheap in my first version. I have now added more comparisons and it seems to work.

I still wonder why it randomly passed the one time it did...