search

aatishb / covidtrends

Tracking the growth of COVID-19 Cases worldwide
https://aatishb.com/covidtrends/
MIT License
301 stars 107 forks source link

Minify style.css, normalize.css and vue-definitions.js #101

Open rpkoller opened 4 years ago

rpkoller commented 4 years ago

At the moment the two css files as well as the definitions file for vue aren't minified.

edg2s commented 4 years ago

These three files total <9kb after gzip, whereas Plotly is 275kb and vue is 33kb.

I would say at the moment introducing a build step to save just a few kb doesn't seem like a worthwhile trade.

rpkoller commented 4 years ago

i agree. just a habit to minify all the asset possible. to perform those steps each time manually isnt worthwhile indeed... just thought in the long run if you would provide some sort of an automation with gulp or webpack you might automate the minification around other things