updating the URL for sharing?

aatishb / covidtrends

Tracking the growth of COVID-19 Cases worldwide

https://aatishb.com/covidtrends/

MIT License

301 stars 107 forks source link

updating the URL for sharing? #183

Closed Pomax closed 4 years ago

Pomax commented 4 years ago

It would be nice if the window.location.search got updated (or a history.replaceState got affected) when selecting things like "Canada" or "reported deaths" + "linear scale", so that you can share the same view with people without having to tell them which options to then click/select before they'll see the same thing.

(mostly to obviate the need for the "shareable link" button)

rpkoller commented 4 years ago

see https://github.com/aatishb/covidtrends/pull/182

Pomax commented 4 years ago

closing as duplicate of https://github.com/aatishb/covidtrends/pull/179

rpkoller commented 4 years ago

@Pomax sorry for the brief answer before! i was cooking dinner aside and was kind in a rush but just saw your question coming in and had read the according pull request few minutes before so i thought just quickly answer and point you there showing that things are already in works :)