search

aatxe / irc

the irc crate – usable, async IRC for Rust
Mozilla Public License 2.0
530 stars 97 forks source link

Logging control? #105

Closed DoumanAsh closed 6 years ago

DoumanAsh commented 6 years ago

There are seems to be some println inside of code. Do you think there should be control over it?

aatxe commented 6 years ago

I agree that we should use logging (via log crate, most likely), and eliminate any printlns. Did you actually encounter any output though? A cursory search seems to turn up only one println that is not inside of a test case, and that would appear only once in a program (and only if they add their own certificate for SSL).

In general, I tried to avoid making the library noisy (with the understanding that there is no logging framework). There is probably places where it would be nice to log info (especially when #88 is done).

DoumanAsh commented 6 years ago

@aatxe Yeah sorry, at first look I thought there are several printlns, but then I examined in details and too found only one rare println on adding certificate path.

To me of course silent irc is better than anything else :)

aatxe commented 6 years ago

This is fixed in 7625c364a6ed22e504c86a01c44fe37dd40d08be. Cheers! 🍻